Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-32] 커스텀 에러코드 적용 #281

Merged
merged 16 commits into from
Jul 19, 2024
Merged

[DEV-32] 커스텀 에러코드 적용 #281

merged 16 commits into from
Jul 19, 2024

Conversation

5uhwann
Copy link
Member

@5uhwann 5uhwann commented Jul 19, 2024

Issue

Close #267

✅ 작업 내용

  • 커스텀 에러 코드 정의
  • ExceptionRexponse 스펙 수정 및 커스텀 에러코드 적용

🤔 고민 했던 부분

🔊 도움이 필요한 부분!!

5uhwann added 16 commits June 3, 2024 00:14
@5uhwann
refactor: custom errorCode 정의
c613177
@5uhwann
Merge branch 'refs/heads/develop' into refactor/DEV-32-apply_custom_e…
b35df69 
…rrorcode
@5uhwann
feat: ExceptionResponse 스펙 수정
eb851fa
@5uhwann
refactor: ErrorCode 추가 및 적용
c3330fa
@5uhwann
refactor: Auth - 로그인 요청 custom errorCode 적용
b37ac3f
@5uhwann
refactor: 수강과목 등록 - pdf parsing text custom errorCode 적용
5e063ac
@5uhwann
feat: StudentCategory - 학생 이수구분 카테고리에 졸업 카테고리가 포함 여부 검증 로직 추가
9847640
@5uhwann
feat: 유저아이디 찾기 커스텀 에러코드 적용
2f385d6
@5uhwann
feat: 유저검증 커스텀 에러코드 적용
1598910
@5uhwann
feat: 비밀번호 재설정 커스텀 에러코드 적용
e6ee555
@5uhwann
feat: 아이디 중복 체크 커스텀 에러코드 적용
6f9cfd5
@5uhwann
feat: 학번 중복 체크정 커스텀 에러코드 적용
5975691
@5uhwann
feat: 회원 탈퇴 커스텀 에러코드 적용
6220eb5
@5uhwann
feat: 회원가입 요청 커스텀 에러코드 적용
b5ad669
@5uhwann
refactor: GlobalExceptionHandler response 스펙 수정
a9f7d75
@5uhwann
refactor: 불필요 import 제거
cb6ddf7
@5uhwann 5uhwann added the ♻️ refactor 기본의 로직 변경 없이 코드 개선 label Jul 19, 2024
@5uhwann 5uhwann self-assigned this Jul 19, 2024
@notion-workspace Notion Workspace
Copy link

예외 케이스 - 커스텀 에러 코드 적용

@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.95%. Comparing base (7debefa) to head (cb6ddf7).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #281      +/-   ##
=============================================
+ Coverage      83.83%   83.95%   +0.12%     
- Complexity       578      580       +2     
=============================================
  Files            152      152              
  Lines           2258     2269      +11     
  Branches          82       83       +1     
=============================================
+ Hits            1893     1905      +12     
+ Misses           319      318       -1     
  Partials          46       46
Files Coverage Δ
...ebe/auth/api/signin/dto/request/SignInRequest.java 100.00% <ø> (ø)
...aduatebe/auth/security/JwtAccessDeniedHandler.java 14.28% <100.00%> (ø)
...ebe/auth/security/JwtAuthenticationEntryPoint.java 14.28% <100.00%> (ø)
...ervice/CalculateSingleDetailGraduationService.java 100.00% <100.00%> (ø)
...e/save/SaveTakenLectureFromParsingTextService.java 100.00% <100.00%> (ø)
...tebe/user/api/findauthid/FindAuthIdController.java 100.00% <ø> (ø)
...ser/api/resetpassword/ResetPasswordController.java 100.00% <ø> (ø)
...esetpassword/dto/request/ResetPasswordRequest.java 100.00% <ø> (ø)
...jigraduatebe/user/api/signup/SignUpController.java 100.00% <ø> (ø)
...ebe/user/api/signup/dto/request/SignUpRequest.java 100.00% <ø> (ø)
... and 8 more

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7debefa...cb6ddf7. Read the comment docs.

@5uhwann 5uhwann added the D-1 label Jul 19, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@5uhwann 5uhwann merged commit ed4acc4 into develop Jul 19, 2024
5 checks passed
@5uhwann 5uhwann deleted the refactor/DEV-32-apply_custom_errorcode branch July 19, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stophwan stophwan Awaiting requested review from stophwan stophwan is a code owner

@Hoya324 Hoya324 Awaiting requested review from Hoya324 Hoya324 is a code owner

Assignees

@5uhwann 5uhwann

Labels
D-1 ♻️ refactor 기본의 로직 변경 없이 코드 개선 size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEV-32] 커스텀 에러코드 적용
1 participant
@5uhwann